Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple in-memory provider configure extension #26189

Closed
wants to merge 1 commit into from

Conversation

WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Sep 27, 2021

Summary of the changes

  • Add simple in-memory provider configure extensions

Contribute to #25192

@WeihanLi WeihanLi marked this pull request as ready for review September 28, 2021 00:10
@ajcvickers
Copy link
Member

@WeihanLi See #25487. We're not convinced this is a good idea, since we recommend people don't use the in-memory provider.

@WeihanLi
Copy link
Contributor Author

@ajcvickers thanks for your reply, I think in-memory provider is not recommended for common business, but is recommended for test, so maybe this would make the in-memory provider register more easier

@roji
Copy link
Member

roji commented Sep 28, 2021

@WeihanLi the use of the in-memory provider is strongly discouraged also for testing purposes, see the docs.

@WeihanLi
Copy link
Contributor Author

Get it, thanks @roji

@WeihanLi WeihanLi closed this Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants