[6.0.1] Allow non-nullable value comparer to be applied on nullable properties #26430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
approved these changes
Oct 22, 2021
|
Not adding a quirk mode as that would just result in an exception being thrown. |
AndriySvyryd
changed the title
ajcvickers
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26429
Description
An exception is thrown when configuring nullable properties with a non-nullable value comparer via pre-convention model configuration.
Customer impact
The only workaround is to avoid using pre-convention model configuration and configure each property explicitly.
How found
Customer report on RC2.
Regression
Yes, from RC1 in #25969. However, this is a new feature in 6.0
Testing
Test for this scenario added in the PR. Tests for value comparers with different nullability are already present, but don't use model building.
Risk
Low; the fix is to not throw an exception for a specific case.