Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use remarks in XML docs #26439

Merged
merged 3 commits into from
Oct 23, 2021
Merged

Use remarks in XML docs #26439

merged 3 commits into from
Oct 23, 2021

Conversation

ajcvickers
Copy link
Member

Fixes #25529

@ajcvickers ajcvickers requested a review from a team October 23, 2021 11:54
roji
roji approved these changes Oct 23, 2021
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup!

Actually reviewed 200, then my index finger got exhausted, 🐑 🇮🇹

src/EFCore.Abstractions/Properties/AbstractionsStrings.Designer.cs Outdated Show resolved Hide resolved
src/EFCore.Cosmos/Extensions/CosmosPropertyBuilderExtensions.cs Outdated Show resolved Hide resolved
src/EFCore.Relational/Metadata/Builders/IConventionDbFunctionBuilder.cs Show resolved Hide resolved
@ajcvickers ajcvickers merged commit f62cf1b into main Oct 23, 2021
@ajcvickers ajcvickers deleted the TheThingsYouSayYourUnremarkableOh1019 branch October 23, 2021 18:28
@roji roji mentioned this pull request Oct 24, 2021
Closed
@ajcvickers ajcvickers mentioned this pull request Nov 4, 2021
Closed
@ajcvickers ajcvickers mentioned this pull request Jul 26, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Be consistent about when/how we use <remarks>
2 participants
@ajcvickers @roji