Check and update service lifetime docs

src/EFCore.Cosmos/Infrastructure/Internal/CosmosModelValidator.cs

@@ -209,7 +209,7 @@ protected virtual void ValidateSharedContainerCompatibility(
                         throughput = currentThroughput;
                     }
                     else if ((throughput.AutoscaleMaxThroughput ?? throughput.Throughput)
-                        != (currentThroughput.AutoscaleMaxThroughput ?? currentThroughput.Throughput))
+                             != (currentThroughput.AutoscaleMaxThroughput ?? currentThroughput.Throughput))
                     {
                         var conflictingEntityType = mappedTypes.First(et => et.GetThroughput() != null);
                         throw new InvalidOperationException(
@@ -219,7 +219,7 @@ protected virtual void ValidateSharedContainerCompatibility(
                                 container));
                     }
                     else if ((throughput.AutoscaleMaxThroughput == null)
-                        != (currentThroughput.AutoscaleMaxThroughput == null))
+                             != (currentThroughput.AutoscaleMaxThroughput == null))
                     {
                         var conflictingEntityType = mappedTypes.First(et => et.GetThroughput() != null);
                         var autoscaleType = throughput.AutoscaleMaxThroughput == null

src/EFCore.Cosmos/Infrastructure/Internal/CosmosSingletonOptions.cs

@@ -7,7 +7,6 @@
 using Microsoft.Azure.Cosmos;
 using Microsoft.EntityFrameworkCore.Diagnostics;
 using Microsoft.EntityFrameworkCore.Infrastructure;
-using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.EntityFrameworkCore.Cosmos.Infrastructure.Internal
 {
@@ -17,11 +16,6 @@ namespace Microsoft.EntityFrameworkCore.Cosmos.Infrastructure.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    /// <remarks>
-    ///     The service lifetime is <see cref="ServiceLifetime.Singleton" />. This means a single instance
-    ///     is used by many <see cref="DbContext" /> instances. The implementation must be thread-safe.
-    ///     This service cannot depend on services registered as <see cref="ServiceLifetime.Scoped" />.
-    /// </remarks>
     public class CosmosSingletonOptions : ICosmosSingletonOptions
     {
         /// <summary>

src/EFCore.Cosmos/Query/Internal/CosmosQueryCompilationContextFactory.cs

@@ -3,7 +3,6 @@
 
 using Microsoft.EntityFrameworkCore.Query;
 using Microsoft.EntityFrameworkCore.Utilities;
-using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.EntityFrameworkCore.Cosmos.Query.Internal
 {
@@ -13,12 +12,6 @@ namespace Microsoft.EntityFrameworkCore.Cosmos.Query.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    /// <remarks>
-    ///     The service lifetime is <see cref="ServiceLifetime.Scoped" />. This means that each
-    ///     <see cref="DbContext" /> instance will use its own instance of this service.
-    ///     The implementation may depend on other services registered with any lifetime.
-    ///     The implementation does not need to be thread-safe.
-    /// </remarks>
     public class CosmosQueryCompilationContextFactory : IQueryCompilationContextFactory
     {
         /// <summary>

src/EFCore.Cosmos/Storage/Internal/CosmosClientWrapper.cs

@@ -22,7 +22,6 @@
 using Microsoft.EntityFrameworkCore.Storage;
 using Microsoft.EntityFrameworkCore.Update;
 using Microsoft.EntityFrameworkCore.Utilities;
-using Microsoft.Extensions.DependencyInjection;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
 
@@ -34,12 +33,6 @@ namespace Microsoft.EntityFrameworkCore.Cosmos.Storage.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    /// <remarks>
-    ///     The service lifetime is <see cref="ServiceLifetime.Scoped" />. This means that each
-    ///     <see cref="DbContext" /> instance will use its own instance of this service.
-    ///     The implementation may depend on other services registered with any lifetime.
-    ///     The implementation does not need to be thread-safe.
-    /// </remarks>
     public class CosmosClientWrapper : ICosmosClientWrapper
     {
         /// <summary>

src/EFCore.Cosmos/Storage/Internal/CosmosDatabaseWrapper.cs

@@ -16,7 +16,6 @@
 using Microsoft.EntityFrameworkCore.Storage;
 using Microsoft.EntityFrameworkCore.Update;
 using Microsoft.EntityFrameworkCore.Utilities;
-using Microsoft.Extensions.DependencyInjection;
 using Newtonsoft.Json.Linq;
 using Database = Microsoft.EntityFrameworkCore.Storage.Database;
 
@@ -28,12 +27,6 @@ namespace Microsoft.EntityFrameworkCore.Cosmos.Storage.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    /// <remarks>
-    ///     The service lifetime is <see cref="ServiceLifetime.Scoped" />. This means that each
-    ///     <see cref="DbContext" /> instance will use its own instance of this service.
-    ///     The implementation may depend on other services registered with any lifetime.
-    ///     The implementation does not need to be thread-safe.
-    /// </remarks>
     public class CosmosDatabaseWrapper : Database
     {
         private readonly Dictionary<IEntityType, DocumentSource> _documentCollections = new();

src/EFCore.Cosmos/Storage/Internal/CosmosExecutionStrategyFactory.cs

@@ -5,7 +5,6 @@
 using Microsoft.EntityFrameworkCore.Cosmos.Infrastructure.Internal;
 using Microsoft.EntityFrameworkCore.Storage;
 using Microsoft.EntityFrameworkCore.Utilities;
-using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.EntityFrameworkCore.Cosmos.Storage.Internal
 {
@@ -15,12 +14,6 @@ namespace Microsoft.EntityFrameworkCore.Cosmos.Storage.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    /// <remarks>
-    ///     The service lifetime is <see cref="ServiceLifetime.Scoped" />. This means that each
-    ///     <see cref="DbContext" /> instance will use its own instance of this service.
-    ///     The implementation may depend on other services registered with any lifetime.
-    ///     The implementation does not need to be thread-safe.
-    /// </remarks>
     public class CosmosExecutionStrategyFactory : IExecutionStrategyFactory
     {
         private readonly Func<ExecutionStrategyDependencies, IExecutionStrategy> _createExecutionStrategy;

src/EFCore.Cosmos/Storage/Internal/CosmosTypeMappingSource.cs

@@ -31,10 +31,7 @@ public CosmosTypeMappingSource(TypeMappingSourceDependencies dependencies)
             : base(dependencies)
         {
             _clrTypeMappings
-                = new Dictionary<Type, CosmosTypeMapping>
-                {
-                    { typeof(JObject), new CosmosTypeMapping(typeof(JObject)) }
-                };
+                = new Dictionary<Type, CosmosTypeMapping> { { typeof(JObject), new CosmosTypeMapping(typeof(JObject)) } };
         }
 
         /// <summary>

src/EFCore.Cosmos/Storage/Internal/SingletonCosmosClientWrapper.cs

@@ -4,7 +4,6 @@
 using Microsoft.Azure.Cosmos;
 using Microsoft.EntityFrameworkCore.Cosmos.Infrastructure.Internal;
 using Microsoft.EntityFrameworkCore.Infrastructure;
-using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.EntityFrameworkCore.Cosmos.Storage.Internal
 {
@@ -14,12 +13,6 @@ namespace Microsoft.EntityFrameworkCore.Cosmos.Storage.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    /// <remarks>
-    ///     The service lifetime is <see cref="ServiceLifetime.Singleton" /> and multiple registrations
-    ///     are allowed. This means a single instance of each service is used by many <see cref="DbContext" />
-    ///     instances. The implementation must be thread-safe.
-    ///     This service cannot depend on services registered as <see cref="ServiceLifetime.Scoped" />.
-    /// </remarks>
     public class SingletonCosmosClientWrapper : ISingletonCosmosClientWrapper
     {
         private static readonly string _userAgent = " Microsoft.EntityFrameworkCore.Cosmos/" + ProductInfo.GetVersion();

src/EFCore.Design/Design/Internal/DesignTimeConnectionStringResolver.cs

@@ -3,7 +3,6 @@
 
 using System;
 using Microsoft.EntityFrameworkCore.Storage.Internal;
-using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.EntityFrameworkCore.Design.Internal
 {
@@ -13,12 +12,6 @@ namespace Microsoft.EntityFrameworkCore.Design.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    /// <remarks>
-    ///     The service lifetime is <see cref="ServiceLifetime.Scoped" />. This means that each
-    ///     <see cref="DbContext" /> instance will use its own instance of this service.
-    ///     The implementation may depend on other services registered with any lifetime.
-    ///     The implementation does not need to be thread-safe.
-    /// </remarks>
     public class DesignTimeConnectionStringResolver : NamedConnectionStringResolverBase, IDesignTimeConnectionStringResolver
     {
         private readonly Func<IServiceProvider>? _applicationServiceProviderAccessor;

src/EFCore.Design/Design/Internal/IDesignTimeConnectionStringResolver.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using Microsoft.EntityFrameworkCore.Storage.Internal;
+using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.EntityFrameworkCore.Design.Internal
 {
@@ -11,6 +12,11 @@ namespace Microsoft.EntityFrameworkCore.Design.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
+    /// <remarks>
+    ///     The service lifetime is <see cref="ServiceLifetime.Singleton" />. This means a single instance
+    ///     is used by many <see cref="DbContext" /> instances. The implementation must be thread-safe.
+    ///     This service cannot depend on services registered as <see cref="ServiceLifetime.Scoped" />.
+    /// </remarks>
     public interface IDesignTimeConnectionStringResolver : INamedConnectionStringResolver
     {
     }

src/EFCore.InMemory/Infrastructure/Internal/InMemorySingletonOptions.cs

@@ -5,7 +5,6 @@
 using Microsoft.EntityFrameworkCore.Diagnostics;
 using Microsoft.EntityFrameworkCore.Infrastructure;
 using Microsoft.EntityFrameworkCore.Storage;
-using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.EntityFrameworkCore.InMemory.Infrastructure.Internal
 {
@@ -15,12 +14,6 @@ namespace Microsoft.EntityFrameworkCore.InMemory.Infrastructure.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    /// <remarks>
-    ///     The service lifetime is <see cref="ServiceLifetime.Singleton" /> and multiple registrations
-    ///     are allowed. This means a single instance of each service is used by many <see cref="DbContext" />
-    ///     instances. The implementation must be thread-safe.
-    ///     This service cannot depend on services registered as <see cref="ServiceLifetime.Scoped" />.
-    /// </remarks>
     public class InMemorySingletonOptions : IInMemorySingletonOptions
     {
         /// <summary>

src/EFCore.InMemory/Query/Internal/InMemoryQueryContextFactory.cs

@@ -4,7 +4,6 @@
 using Microsoft.EntityFrameworkCore.Infrastructure;
 using Microsoft.EntityFrameworkCore.InMemory.Storage.Internal;
 using Microsoft.EntityFrameworkCore.Query;
-using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.EntityFrameworkCore.InMemory.Query.Internal
 {
@@ -14,12 +13,6 @@ namespace Microsoft.EntityFrameworkCore.InMemory.Query.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    /// <remarks>
-    ///     The service lifetime is <see cref="ServiceLifetime.Scoped" />. This means that each
-    ///     <see cref="DbContext" /> instance will use its own instance of this service.
-    ///     The implementation may depend on other services registered with any lifetime.
-    ///     The implementation does not need to be thread-safe.
-    /// </remarks>
     public class InMemoryQueryContextFactory : IQueryContextFactory
     {
         private readonly IInMemoryStore _store;

src/EFCore.InMemory/Query/Internal/InMemoryQueryableMethodTranslatingExpressionVisitorFactory.cs

@@ -3,7 +3,6 @@
 
 using Microsoft.EntityFrameworkCore.Query;
 using Microsoft.EntityFrameworkCore.Utilities;
-using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.EntityFrameworkCore.InMemory.Query.Internal
 {
@@ -13,11 +12,6 @@ namespace Microsoft.EntityFrameworkCore.InMemory.Query.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    /// <remarks>
-    ///     The service lifetime is <see cref="ServiceLifetime.Singleton" />. This means a single instance
-    ///     is used by many <see cref="DbContext" /> instances. The implementation must be thread-safe.
-    ///     This service cannot depend on services registered as <see cref="ServiceLifetime.Scoped" />.
-    /// </remarks>
     public class InMemoryQueryableMethodTranslatingExpressionVisitorFactory : IQueryableMethodTranslatingExpressionVisitorFactory
     {
         /// <summary>

src/EFCore.InMemory/Storage/Internal/InMemoryDatabase.cs

@@ -10,7 +10,6 @@
 using Microsoft.EntityFrameworkCore.Storage;
 using Microsoft.EntityFrameworkCore.Update;
 using Microsoft.EntityFrameworkCore.Utilities;
-using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.EntityFrameworkCore.InMemory.Storage.Internal
 {
@@ -20,12 +19,6 @@ namespace Microsoft.EntityFrameworkCore.InMemory.Storage.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    /// <remarks>
-    ///     The service lifetime is <see cref="ServiceLifetime.Scoped" />. This means that each
-    ///     <see cref="DbContext" /> instance will use its own instance of this service.
-    ///     The implementation may depend on other services registered with any lifetime.
-    ///     The implementation does not need to be thread-safe.
-    /// </remarks>
     public class InMemoryDatabase : Database, IInMemoryDatabase
     {
         private readonly IInMemoryStore _store;

src/EFCore.InMemory/Storage/Internal/InMemoryDatabaseCreator.cs

@@ -5,7 +5,6 @@
 using System.Threading.Tasks;
 using Microsoft.EntityFrameworkCore.Storage;
 using Microsoft.EntityFrameworkCore.Utilities;
-using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.EntityFrameworkCore.InMemory.Storage.Internal
 {
@@ -15,12 +14,6 @@ namespace Microsoft.EntityFrameworkCore.InMemory.Storage.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    /// <remarks>
-    ///     The service lifetime is <see cref="ServiceLifetime.Scoped" />. This means that each
-    ///     <see cref="DbContext" /> instance will use its own instance of this service.
-    ///     The implementation may depend on other services registered with any lifetime.
-    ///     The implementation does not need to be thread-safe.
-    /// </remarks>
     public class InMemoryDatabaseCreator : IDatabaseCreator
     {
         private readonly IDatabase _database;

src/EFCore.InMemory/Storage/Internal/InMemoryTransactionManager.cs

@@ -8,7 +8,6 @@
 using Microsoft.EntityFrameworkCore.InMemory.Internal;
 using Microsoft.EntityFrameworkCore.Storage;
 using Microsoft.EntityFrameworkCore.Utilities;
-using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.EntityFrameworkCore.InMemory.Storage.Internal
 {
@@ -18,12 +17,6 @@ namespace Microsoft.EntityFrameworkCore.InMemory.Storage.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    /// <remarks>
-    ///     The service lifetime is <see cref="ServiceLifetime.Scoped" />. This means that each
-    ///     <see cref="DbContext" /> instance will use its own instance of this service.
-    ///     The implementation may depend on other services registered with any lifetime.
-    ///     The implementation does not need to be thread-safe.
-    /// </remarks>
     public class InMemoryTransactionManager : IDbContextTransactionManager, ITransactionEnlistmentManager
     {
         private static readonly InMemoryTransaction _stubTransaction = new();

src/EFCore.InMemory/Storage/Internal/InMemoryTypeMappingSource.cs

@@ -6,7 +6,6 @@
 using Microsoft.EntityFrameworkCore.ChangeTracking;
 using Microsoft.EntityFrameworkCore.Storage;
 using Microsoft.EntityFrameworkCore.Utilities;
-using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.EntityFrameworkCore.InMemory.Storage.Internal
 {
@@ -16,11 +15,6 @@ namespace Microsoft.EntityFrameworkCore.InMemory.Storage.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    /// <remarks>
-    ///     The service lifetime is <see cref="ServiceLifetime.Singleton" />. This means a single instance
-    ///     is used by many <see cref="DbContext" /> instances. The implementation must be thread-safe.
-    ///     This service cannot depend on services registered as <see cref="ServiceLifetime.Scoped" />.
-    /// </remarks>
     public class InMemoryTypeMappingSource : TypeMappingSource
     {
         /// <summary>

src/EFCore.InMemory/ValueGeneration/Internal/InMemoryValueGeneratorSelector.cs

@@ -7,7 +7,6 @@
 using Microsoft.EntityFrameworkCore.Metadata;
 using Microsoft.EntityFrameworkCore.Utilities;
 using Microsoft.EntityFrameworkCore.ValueGeneration;
-using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.EntityFrameworkCore.InMemory.ValueGeneration.Internal
 {
@@ -17,12 +16,6 @@ namespace Microsoft.EntityFrameworkCore.InMemory.ValueGeneration.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    /// <remarks>
-    ///     The service lifetime is <see cref="ServiceLifetime.Scoped" />. This means that each
-    ///     <see cref="DbContext" /> instance will use its own instance of this service.
-    ///     The implementation may depend on other services registered with any lifetime.
-    ///     The implementation does not need to be thread-safe.
-    /// </remarks>
     public class InMemoryValueGeneratorSelector : ValueGeneratorSelector
     {
         private readonly IInMemoryStore _inMemoryStore;