[6.0.1] Avoid NRE in ForeignKeyAttributeConvention #26520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
Issue26436
branch
from
39c0135
to
25ab6be
Compare
ajcvickers
approved these changes
Nov 3, 2021
AndriySvyryd
changed the title
ajcvickers
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26436
Description
An exception is thrown when configuring a foreign key on the principal side of the foreign key configured by data annotations.
Customer impact
There aren't simple workarounds other than removing the attribute, because the exception is thrown during a convention invocation.
How found
Customer report on RC2.
Regression
Yes, from 5.0, introduced in #25211.
Testing
Test for this scenario added in the PR.
Risk
Low; the fix is adding a
nullcheck that existed previously. Not adding a quirk mode as that would just result in an exception being thrown.