[6.0.1] Query: Optimize Contains to Any recursively #26599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
approved these changes
Nov 10, 2021
ajcvickers
approved these changes
Nov 11, 2021
|
Approved for 6.0.1. |
|
@smitpatel I can merge this once conflicts are resolved |
- Also unwrap convert node around projection when translating Contains Resolves #26593
smitpatel
force-pushed
the
smit/patchysnow1
branch
from
baea533
to
756554b
Compare
|
Should be moved to https://github.com/dotnet/efcore/milestone/130?closed=1 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26593
Description
When writing query which has multiple subquery Contains if the inner Contains is on entity type or value type then translation fails.
Customer impact
User query will throw exception with no easy way to figure out work-around
How found
Customer reported on RTM package
Regression
Yes, the query worked in 5.0 release.
Testing
Added test for customer scenario and similar kind of queries.
Risk
Low. Recursive visit should be no-op if there is no other relevant parts inside. Also added quirk to go back to earlier behavior.