Generate change-tracking delegates in the compiled model. #31443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
NativeAOT_part3
branch
from
f1f199e to
1f1e4b3
Compare
AndriySvyryd
force-pushed
the
NativeAOT_part3
branch
2 times, most recently
from
78d8e80 to
1a531e7
Compare
ajcvickers
reviewed
Jan 23, 2024
src/EFCore.Design/Query/Internal/LinqToCSharpSyntaxTranslator.cs
Outdated
Show resolved
Hide resolved
ajcvickers
reviewed
Jan 23, 2024
| /// any release. You should only use it directly in your code with extreme caution and knowing that | ||
| /// doing so can result in application failures when updating to a new Entity Framework Core release. | ||
| /// </summary> | ||
| public static readonly MethodInfo PopulateListMethod |
There was a problem hiding this comment.
Should this move to a common, public, location?
There was a problem hiding this comment.
It points to a method on a pubternal class. To me it makes sense for it to be pubternal as well.
ajcvickers
approved these changes
Jan 23, 2024
|
FYI starting to review (especially the LinqToCSharp changes). |
roji
requested changes
Jan 24, 2024
src/EFCore.Design/Query/Internal/ILinqToCSharpSyntaxTranslator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Design/Query/Internal/LinqToCSharpSyntaxTranslator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Design/Query/Internal/LinqToCSharpSyntaxTranslator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Design/Query/Internal/LinqToCSharpSyntaxTranslator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Design/Query/Internal/LinqToCSharpSyntaxTranslator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Design/Query/Internal/LinqToCSharpSyntaxTranslator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Design/Query/Internal/LinqToCSharpSyntaxTranslator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Design/Query/Internal/LinqToCSharpSyntaxTranslator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Design/Query/Internal/LinqToCSharpSyntaxTranslator.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
force-pushed
the
NativeAOT_part3
branch
from
1a531e7 to
a71232e
Compare
roji
reviewed
Jan 26, 2024
src/EFCore.Design/Query/Internal/LinqToCSharpSyntaxTranslator.cs
Outdated
Show resolved
Hide resolved
roji
reviewed
Jan 26, 2024
src/EFCore.Design/Query/Internal/LinqToCSharpSyntaxTranslator.cs
Outdated
Show resolved
Hide resolved
roji
reviewed
Jan 26, 2024
| /// </summary> | ||
| protected virtual ExpressionSyntax GenerateValue(object? value) | ||
| { | ||
| return value switch |
There was a problem hiding this comment.
Can't, contains local functions that you like so much
roji
reviewed
Jan 26, 2024
src/EFCore.Design/Query/Internal/LinqToCSharpSyntaxTranslator.cs
Outdated
Show resolved
Hide resolved
roji
reviewed
Jan 26, 2024
| // return NullableType(Translate(type.GenericTypeArguments[0])); | ||
| //} | ||
|
|
||
| var generic = GenericName( |
There was a problem hiding this comment.
I think we need this logic to produce fully-qualified names, to avoid the usual ambiguities etc. (unrelated to this PR).
roji
reviewed
Jan 26, 2024
src/EFCore.Design/Query/Internal/RuntimeModelLinqToCSharpSyntaxTranslator.cs
Show resolved
Hide resolved
roji
requested changes
Jan 26, 2024
roji
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #29761
Still missing private constructors and service property bindings