Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully implement element nullability for primitive collections #31468

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Fully implement element nullability for primitive collections #31468

merged 1 commit into from
Aug 15, 2023

Conversation

roji
Copy link
Member

@roji roji commented Aug 15, 2023 •
edited
Loading

  • Update NonNullableReferencePropertyConvention to detect non-nullable reference types for the element CLR type of primitive collection, and to apply that to EF's element metadata.
  • In the query pipeline, properly extract element nullability from metadata and create the correct column nullability when translating primitive collections.

Closes #31416

/cc @danmoseley

@roji roji requested a review from ajcvickers August 15, 2023 09:19
@roji roji changed the base branch from main to release/8.0-rc1 August 15, 2023 09:19
@roji roji force-pushed the PrimitiveCollectionElementNullability branch 2 times, most recently from b8d45af to bf0abd1 Compare August 15, 2023 13:35
ajcvickers
ajcvickers reviewed Aug 15, 2023
View reviewed changes
Copy link
Contributor

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 🇮🇹

@roji roji force-pushed the PrimitiveCollectionElementNullability branch from bf0abd1 to 0c57357 Compare August 15, 2023 16:58
@roji
Copy link
Member Author

roji commented Aug 15, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@roji roji merged commit 4758685 into dotnet:release/8.0-rc1 Aug 15, 2023
@roji roji deleted the PrimitiveCollectionElementNullability branch August 15, 2023 19:35
Tratcher pushed a commit that referenced this pull request Aug 15, 2023
@dotnet-maestro-bot @roji
Fully implement element nullability for primitive collections (#31468) (
d9ac1ff 
#31473)

Closes #31416

Co-authored-by: Shay Rojansky <roji@roji.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NRT metadata is not used for element type nullability
2 participants
@roji @ajcvickers