Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API review updates #31495

Merged
merged 1 commit into from
Aug 17, 2023
Merged

API review updates #31495

merged 1 commit into from
Aug 17, 2023

Conversation

ajcvickers
Copy link
Contributor

@ajcvickers ajcvickers commented Aug 17, 2023

Part of #30306

  • Rename IClrPropertyGetter.HasSentinelValue to just HasSentinel
  • Make IdValueGeneratorFactory in Cosmos pubternal
  • Undo the source breaking change to RelationalGeometryTypeMapping.ctor (move reader/writer to the end, default to null)
  • Rename WKT to Wkt everywhere
  • Remove Try from TypeMappingSource.TryFindCollectionMapping
  • Rename JsonNullableStuctsCollectionReaderWriter to JsonNullableStructCollectionReaderWriter
  • Seal JsonValueReaderWriter.FromJsonString and ToJsonString

@ajcvickers ajcvickers requested a review from a team August 17, 2023 16:20
@ajcvickers
Copy link
Contributor Author

/cc @danmoseley

- Rename IClrPropertyGetter.HasSentinelValue to just HasSentinel
- Make IdValueGeneratorFactory in Cosmos pubternal
- Undo the source breaking change to RelationalGeometryTypeMapping.ctor (move reader/writer to the end, default to null)
- Rename WKT to Wkt everywhere
- Remove Try from TypeMappingSource.TryFindCollectionMapping
- Rename JsonNullableStuctsCollectionReaderWriter to JsonNullableStructCollectionReaderWriter
- Seal JsonValueReaderWriter.FromJsonString and ToJsonString
@danmoseley
Copy link
Member

sounds good if it goes in before tomorrow

@ajcvickers ajcvickers merged commit 53117cf into release/8.0-rc1 Aug 17, 2023
@ajcvickers ajcvickers deleted the 230817_ApeWaffles branch August 17, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants