Allow to ignore attributes when finding type mapping #32193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
Issue11124
branch
from
513ab10 to
2b0b576
Compare
ajcvickers
reviewed
Nov 2, 2023
| } | ||
|
|
||
| /// <inheritdoc/> | ||
| public override RelationalTypeMapping? FindMapping(MemberInfo member, IModel model, bool useAttributes) |
There was a problem hiding this comment.
I don't override any of these FindMapping overloads (which accept MemberInfo) in Npgsql, only the version which accepts RelationalTypeMappingInfo... That should be OK, right?
ajcvickers
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make existing model building conventions more extensible
Fixes #11124
Fixes #28866