Move compiled model tests to EFCore.Specification.Tests #32341
Conversation
AndriySvyryd
force-pushed
the
Issue32315
branch
from
abf4c18 to
1e5f145
Compare
AndriySvyryd
force-pushed
the
Issue32315
branch
from
1e5f145 to
f44192f
Compare
| .HasOriginalValueParameter(p => p.Id)); | ||
| eb.DeleteUsingStoredProcedure( | ||
| s => s | ||
| .HasRowsAffectedReturnValue() |
There was a problem hiding this comment.
@AndriySvyryd this means EFCore.PG can't test for TPC, since return values from sprocs are a SQL Server thing. Ideally, this test would only exercise functionality needed for TPC, and sproc testing would be exercised by another test etc.
Same for the ComplexTypes test.
There was a problem hiding this comment.
If you think there's EFCore.PG-specific functionality that could be covered by this then file an issue please
There was a problem hiding this comment.
It's more about making the Tpc and ComplexTypes tests runnable on EFCore.PG (i.e. making them not use sprocs with return values, ideally not sprocs at all). I'll indeed want to look at opportunities for covering some PG functionality, but that's separate...
Anyway, opened #33075.
Fix NRT annotations for the
ComplexPropertyfluent API.Add validation for sentinel values.
Scaffold unmapped default values for flags enum correctly.
Part of #32315