Update developer docs for building packages and using developer build config #32597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much, this is very helpful! Does all tests currently pass on an international machine? Or would you like me to check? |
|
@ErikEJ I haven't tested that for a long time, so by all means go ahead! |
ErikEJ
reviewed
Dec 12, 2023
|
@ajcvickers it is not good, I am in the process of updating #22901 Maybe at least add a note about this in the build guide? And maybe leave as is, closing #22901? It is quite confusing for new contributors trying to run the tests locally - was it my changes or?? |
AndriySvyryd
approved these changes
Dec 14, 2023
ajcvickers
force-pushed
the
231212_PackageMe
branch
from
39ba6a8 to
7074536
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25278
Fixes #19814
Fixes #27527