Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update daily build screenshot to show a daily build #32856

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

ajcvickers
Copy link
Contributor

@ajcvickers ajcvickers commented Jan 18, 2024

Fixes #32624

@ajcvickers ajcvickers requested a review from a team January 18, 2024 10:49
@ajcvickers ajcvickers merged commit b788a0d into main Jan 18, 2024
7 checks passed
@ajcvickers ajcvickers deleted the ajcvickers-dailyimage branch January 18, 2024 12:29
@@ -79,7 +79,7 @@ Using wildcards will cause NuGet to pull the latest daily build whenever package

You can use your IDE to choose the latest version. For example, in Visual Studio:

![image](https://github.com/dotnet/efcore/assets/91606949/4c7c5838-0500-453e-929b-0bc2c4d5fb35)
![image](![image](https://github.com/dotnet/efcore/assets/1430078/9a54546b-f969-4409-868b-0fa675b162c6))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format is wrong, should be
![image](https://github.com/dotnet/efcore/assets/1430078/9a54546b-f969-4409-868b-0fa675b162c6)

Also why is the image padded with white background?

@ajcvickers
Copy link
Contributor Author

@AndriySvyryd When I click on my link above, it looks like this:

image

When I click on your link, it looks like this:

image

I'm struggling to see the difference...

@AndriySvyryd
Copy link
Member

The image is the same, the code is incorrect. It doesn't render https://github.com/dotnet/efcore/blob/main/docs/DailyBuilds.md#using-an-explicit-version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update daily build image to actually show daily builds
3 participants