Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging: All-up logging improvements: #3300

Closed
wants to merge 0 commits into from
Closed

Logging: All-up logging improvements: #3300

wants to merge 0 commits into from

Conversation

anpete
Copy link
Contributor

@anpete anpete commented Oct 1, 2015

  • New DbContextOption "LogSqlParameterValues()" replacing use of Debug log level to control sensitive data logging.
  • Use a wrapping ILogger in relational to transparently enforce sensitive data logging.
  • More consistentizing of logging usage, DI etc.
  • Better structured logging of DbCommands.
  • Use assembly scoped enums for event ids.
  • Use event ids everywhere.

Fix #1374, #2490

@anpete anpete force-pushed the logging_sql2 branch 2 times, most recently from 9dcfa31 to 0373f57 Compare October 1, 2015 21:30
ajcvickers
ajcvickers reviewed Oct 1, 2015
View reviewed changes
...ityFramework.Relational/Infrastructure/RelationalEntityFrameworkServicesBuilderExtensions.cs
@@ -110,4 +114,54 @@ private static IRelationalDatabaseProviderServices GetProviderServices(IServiceP
return providerServices;
}
}

public interface ILogSqlParameterValuesAccessor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to its own file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

@ajcvickers
Copy link
Contributor

:shipit:

@anpete anpete closed this Oct 1, 2015
@anpete anpete deleted the logging_sql2 branch October 1, 2015 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anpete @ajcvickers @dnfclas