Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes done during EFCore.PG 9.0.0-preview.1 sync #33060

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

roji
Copy link
Member

@roji roji commented Feb 11, 2024

No description provided.

@roji roji requested a review from maumar February 11, 2024 17:12
@@ -4042,7 +4042,7 @@ public virtual Task Correlated_projection_with_first(bool async)
public virtual Task Max_in_multi_level_nested_subquery(bool async)
=> AssertQuery(
async,
ss => ss.Set<Level1>().Take(2).Select(x => new
ss => ss.Set<Level1>().OrderBy(l1 => l1.Id).Take(2).Select(x => new
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will change SQL as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, will fix.

@roji roji marked this pull request as ready for review February 11, 2024 20:09
@roji roji merged commit b6bc42f into dotnet:main Feb 12, 2024
7 checks passed
@roji roji deleted the SmallStuff branch February 12, 2024 09:14
ranma42 added a commit to ranma42/efcore that referenced this pull request Jun 30, 2024
roji pushed a commit that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants