Forcibly sets "en-US" locale. #33291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Mar 11, 2024
* English locale is needed for comparisons, string to number parsing, etc. operations to succeed. * It does not deal with locale on the database side, which might result in i.e. different sorting and hence tests failing.
AndriySvyryd
approved these changes
Mar 12, 2024
This was referenced Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only these 4 projects need it (at the moment). I don't think it's worth adding it into all...
This fixes the handful of failures for me on non-English locale.
Note: It needs to be linked file, because it is using
ModuleInitializer.See also: #14912, #22901