[main] Update dependencies from dotnet/runtime #33821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…0525.1 Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Logging , System.Text.Json From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24275.1
![dotnet-policy-service[bot]](https://avatars.githubusercontent.com/in/285228?s=60&v=4){kind=small}
The FrameworkReference in efcore is already set to honor these, but versions were never set.
ericstj
force-pushed
the
darc-main-66f10065-56c2-4e07-bce6-6ec16857e143
branch
from
893276d to
09d85a0
Compare
AndriySvyryd
approved these changes
May 28, 2024
dotnet-maestro
bot
deleted the
darc-main-66f10065-56c2-4e07-bce6-6ec16857e143
branch
ajcvickers
reviewed
May 29, 2024
| @@ -1698,7 +1698,7 @@ public virtual Task TrimStart_with_char_argument_in_predicate(bool async) | |||
| public virtual Task TrimStart_with_char_array_argument_in_predicate(bool async) | |||
| => AssertQuery( | |||
| async, | |||
| ss => ss.Set<Customer>().Where(c => c.ContactTitle.TrimStart('O', 'w') == "ner")); | |||
| ss => ss.Set<Customer>().Where(c => c.ContactTitle.TrimStart(new [] {'O', 'w'}) == "ner")); | |||
There was a problem hiding this comment.
@AndriySvyryd Is this break going to hit our customers? Should it not be fixed in the runtime/BCL?
ViktorHofer
reviewed
May 29, 2024
| @@ -119,7 +119,7 @@ stages: | |||
| - script: "echo ##vso[build.addbuildtag]CodeQL3000" | |||
| displayName: 'Set CI CodeQL3000 tag' | |||
| condition: ne(variables.CODEQL_DIST,'') | |||
| - script: eng\common\cibuild.cmd -configuration $(_BuildConfig) -prepareMachine $(_InternalBuildArgs) | |||
| - script: eng\common\cibuild.cmd -configuration $(_BuildConfig) -prepareMachine /bl:artifacts\log\$(_BuildConfig)\Build.binlog $(_InternalBuildArgs) | |||
There was a problem hiding this comment.
Curious, why was this necessary? AFAIK this should already be the default when calling into the cibuild.cmd/sh script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/runtime