Translate logical Boolean operators as conditional Boolean operators #33873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In C# the expected results of logical Boolean operators are the same as those of the conditional Boolean operators, as per the [documentation](https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/operators/boolean-logical-operators#nullable-boolean-logical-operators). Instead, in SQL logical operators propagate NULLs. It is possible to avoid complex translations by simply mapping the logical operators to the corresponding conditional ones for Boolean expressions. Fixes dotnet#30245.
maumar
approved these changes
Jun 3, 2024
|
great optimization, loving the new sql, thanks @ranma42 ! |
ranma42
added a commit
to ranma42/efcore
that referenced
this pull request
Jun 3, 2024
After dotnet#33873 EFCore emits different queries for the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C# the expected results of logical Boolean operators are the same as those of the conditional Boolean operators (they differ in not being short-circuited); see here.
Instead, in SQL logical operators propagate NULLs. It is possible to avoid complex translations by simply mapping the logical operators to the corresponding conditional ones for Boolean expressions.
Fixes #30245.