Remove unneeded Cosmos 3-value logic compensation for InExpression #33899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
reviewed
Jun 5, 2024
| @@ -1969,7 +1968,7 @@ public override Task Contains_with_local_collection_empty_inline(bool async) | |||
| """ | |||
| SELECT c | |||
| FROM root c | |||
| WHERE ((c["Discriminator"] = "Customer") AND NOT((true = false))) | |||
| WHERE ((c["Discriminator"] = "Customer") AND NOT(false)) | |||
There was a problem hiding this comment.
Almost a good translation now 😆
There was a problem hiding this comment.
Yeah, there's still a ways to go... :)
The real question here IMHO is how to e.g. implement optimizations without being forced to fully re-implement everything for each provider (relational, Cosmos...) - that simply doesn't scale... I have some thoughts on it for down the road...
AndriySvyryd
approved these changes
Jun 5, 2024
roji
force-pushed
the
RemoveCosmosInNullability
branch
from
c46500e to
f020387
Compare
roji
force-pushed
the
RemoveCosmosInNullability
branch
from
f020387 to
4e3c531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is based on top of #33895, review 2nd commit onlyCloses #31063