-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Nullable<bool>.ToString()
conversion
#33940
Conversation
e29e284
to
65d134e
Compare
There are some product changes here. Consider splitting them out to make this pr test only, alternatively pull in the product changes for #33938 into one pr and update the PR description. Changes look good though. |
65d134e
to
e766b56
Compare
@maumar I moved the test updates and dataset changes in I am not 100% sure if this is the "product changes"/all of them; I did not include the tests that were being added as I thought that they might belong to the specific fix/changeset. Note that in order to ensure that the test suite passes, I disabled EDIT: I also updated the title and first message of the PR to make it clearer that this one takes care of the fixing, while the other one only improves the tests. |
null
value in bool?
column and fix ToString
conversionNullable<bool>.ToString()
conversion
e766b56
to
00bc998
Compare
00bc998
to
3ff9b77
Compare
Nullable values convert to an empty string.
The code was previously only treating nullable `ColumnExpression`s as nullable.
3ff9b77
to
a2f48ee
Compare
yup :) rebased and pushed this one 👍 also, in case it happens with your own commits (and/or with branches you have not replicated elsewhere, remember that |
phew! Thanks making the PR (twice! ;) ) @ranma42 |
This PR updates translation of
bool?
expressions in 2 ways:null
is now converted into the empty string, matching the usual C# behaviorFixes #33941 for SQLite.
Contributes to #33942.