Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid division by decimal 0 in SQLite #33989

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Conversation

ranma42
Copy link
Contributor

@ranma42 ranma42 commented Jun 14, 2024

Fixes #33877

ranma42 added 5 commits June 14, 2024 08:20
It tests arithmetic operators also on division/modulus by 0 and on NULLs.
Instead of dividing by 0 (which triggers an exception), return a `null`, which
is consistent with the usual SQL behavior.
Copy link
Contributor

@cincuranet cincuranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cincuranet cincuranet merged commit f0a733d into dotnet:main Jun 14, 2024
7 checks passed
@ranma42 ranma42 deleted the decimal-divmod-0 branch June 14, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DivideByZeroException in ef_divide and ef_mod
2 participants