Cosmos querying over arrays of structural type #33998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2024
roji
force-pushed
the
CosmosStructuralQuerying
branch
from
39f890e to
92f348b
Compare
Closes dotnet#16926 Closes dotnet#20441 Closes dotnet#29497 Closes dotnet#25700 Closes dotnet#25701 Closes dotnet#33032
roji
force-pushed
the
CosmosStructuralQuerying
branch
from
92f348b to
f4c0b07
Compare
src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds general support for querying over arrays of structural types in Cosmos. Most translations work, various problems and edge cases are tracked separately.
Note that this PR introduces a bit of expression type explosion, with many types representing the same NoSQL syntax (but returning different things, i.e. scalar vs. structural type). See #33999 for more information, hopefully we clean this up at some point.
Closes #16926
Closes #20441
Closes #25700
Closes #25701
Closes #33032