Addressing API review feedback #34321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change ReplacingExpressionVisitor.Replace to IReadOnlyList<Expression> parameters Make ReaderColumn.GetFieldValueExpression and the new constructor experimental. Make ReaderColumn.Create experimental. Make ReaderColumn<T> constructor experimental.
|
Did not add old constructors like we initially planned, because having a ctor with Expression<Func<DbDataReader, int[], T>> (new ctor) and Func<DbDataReader, int[], T> (old ctor) results in ambiguous exception when trying to invoke the ctor. |
maumar
commented
Jul 30, 2024
| @@ -30,6 +31,7 @@ public abstract class ReaderColumn | |||
| /// <param name="name">The name of the column.</param> | |||
| /// <param name="property">The property being read if any, null otherwise.</param> | |||
| /// <param name="getFieldValueExpression">A lambda expression to get field value for the column from the reader.</param> | |||
| [Experimental(EFDiagnostics.PrecompiledQueryExperimental)] | |||
There was a problem hiding this comment.
should these ctors still be experimental, now that we are not adding the old ones back?
There was a problem hiding this comment.
I would leave it experimental, but I don't think it matters too much at this level in the stack.
ajcvickers
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change ReplacingExpressionVisitor.Replace to IReadOnlyList parameters Make ReaderColumn.GetFieldValueExpression and the new constructor experimental. Make ReaderColumn.Create experimental.
Make ReaderColumn constructor experimental.