Remove migration lock timeout #34338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
commented
Aug 2, 2024
|
See comment on possibly continuing to have cancellation and timeout, but fully client-managed: #34196 (comment) |
AndriySvyryd
force-pushed
the
Issue17578_followup
branch
2 times, most recently
from
922be3c to
f8ca271
Compare
|
Follow-up from the API review: using TLDR: it just works! |
AndriySvyryd
force-pushed
the
Issue17578_followup
branch
from
f8ca271 to
9a5e8c6
Compare
|
/azp run |
AndriySvyryd
force-pushed
the
Issue17578_followup
branch
2 times, most recently
from
faf7b1c to
5bcf44f
Compare
roji
approved these changes
Aug 13, 2024
AndriySvyryd
force-pushed
the
Issue17578_followup
branch
from
5bcf44f to
6644f5f
Compare
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log migration lock acquisition
Move seeding to options
Fixes #34196
Fixes #17578