Optimize away DISTINCT inside IN/EXISTS/set operations #34381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me @ranma42 - any issues or further work that prevents merging (remember the feature work deadline is approaching very fast) |
|
I just need to fix the cosmos tests 😇 (well, I will probably mark them as expected failures, just like the similar cases 😈 ) |
ranma42
force-pushed
the
exists-no-distinct-31016
branch
from
70fc0d5 to
5b62da3
Compare
Test translation for set operations and EXISTS/IN on DISTINCT.
ranma42
force-pushed
the
exists-no-distinct-31016
branch
from
5b62da3 to
4c7d9d5
Compare
roji
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes away
DISTINCTwhen immediately inside IN/EXISTS/set operations.Fixes #31016.