API review updates: #34403
Merged
API review updates: #34403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `AlwaysCreateShadowIdProperty` to `HasShadowId` and `HasShadowIds` (on the model builder) - Rename `IncludeDiscriminatorInJsonId` to `HasDiscriminatorInJsonId` and `HasDiscriminatorInJsonIds`. Same for the related methods - Rename `DiscriminatorInKeyBehavior` to `IdDiscriminatorMode` and move it to `Microsoft.EntityFrameworkCore.Metadata` - Rename `DiscriminatorInKeyBehavior.(Root)EntityTypeName` to `(Root)EntityType` - Move `ETagPropertyConvention` to `Microsoft.EntityFrameworkCore.Metadata.Conventions` - Consider merging `CosmosKeyAugmenterConvention` with `CosmosKeyDiscoveryConvention`, otherwise propose a better name for it. - Tried it. Got messy. Renamed to `CosmosPartitionKeyInPrimaryKeyConvention`. I'm sure it will be dicussed again. - Check why the obsolete methods on `RelationalSqlTranslatingExpressionVisitor` haven't been removed in the initial pass - Because it seems we didn't do the pass at the start of EF9
Did you do a pass now to see if there are any other members that should be removed? |
AndriySvyryd
approved these changes
Aug 11, 2024
Not yet. It may be too late for 9 anyway. Let's discuss in the meeting later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AlwaysCreateShadowIdPropertytoHasShadowIdandHasShadowIds(on the model builder)IncludeDiscriminatorInJsonIdtoHasDiscriminatorInJsonIdandHasDiscriminatorInJsonIds. Same for the related methodsDiscriminatorInKeyBehaviortoIdDiscriminatorModeand move it toMicrosoft.EntityFrameworkCore.MetadataDiscriminatorInKeyBehavior.(Root)EntityTypeNameto(Root)EntityTypeETagPropertyConventiontoMicrosoft.EntityFrameworkCore.Metadata.ConventionsCosmosKeyAugmenterConventionwithCosmosKeyDiscoveryConvention, otherwise propose a better name for it.CosmosPartitionKeyInPrimaryKeyConvention. I'm sure it will be dicussed again.RelationalSqlTranslatingExpressionVisitorhaven't been removed in the initial pass