(RC2) (Test only) Code cleanup (Tests) #34490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
changed the title
|
/cc @artl93 |
roji
approved these changes
Aug 21, 2024
| @@ -1525,8 +1524,21 @@ protected override void OnModelCreating(ModelBuilder modelBuilder) | |||
| => modelBuilder.Entity<Customer>( | |||
| cb => | |||
| { | |||
| cb.HasPartitionKey(c => new { c.PartitionKey1, c.PartitionKey2, c.PartitionKey3 }); | |||
| cb.HasKey(c => new { c.Id, c.PartitionKey1, c.PartitionKey2, c.PartitionKey3 }); | |||
| cb.HasPartitionKey( | |||
There was a problem hiding this comment.
Am sad about these (doesn't seem like they reach our line char limit) but whatever
There was a problem hiding this comment.
Our rules say we always expand these. Not a fan of it either.
test/EFCore.Cosmos.FunctionalTests/Query/InheritanceQueryCosmosFixture.cs
Outdated
Show resolved
Hide resolved
test/EFCore.Cosmos.FunctionalTests/Query/InheritanceQueryCosmosFixture.cs
Outdated
Show resolved
Hide resolved
| @@ -371,28 +371,28 @@ private static List<SinglePartitionKeyEntity> CreateSinglePartitionKeyEntities() | |||
| private static List<OnlyHierarchicalPartitionKeyEntity> CreateOnlyHierarchicalPartitionKeyEntities() | |||
| => new() | |||
| { | |||
| new() | |||
| new OnlyHierarchicalPartitionKeyEntity | |||
There was a problem hiding this comment.
My preference on these would be to explicitly specify the list type (new List<OnlyHierarchyPartitionKeyEntity>() just above) and then use target-typed new in the elements - hopefully the editorconfig setting allows for that... But no need to block this PR for that.
| @@ -384,7 +384,7 @@ protected override Task SeedAsync(PoolableDbContext context) | |||
| NestedOwned = new Owned2 { Prop = "7" }, | |||
| NestedOwnedCollection = new List<Owned2> { new() { Prop = "71" }, new() { Prop = "72" } } | |||
| }, | |||
| OwnedCollection = new List<Owned1> { new Owned1 { Prop = 71 }, new Owned1 { Prop = 72 } } | |||
| OwnedCollection = new List<Owned1> { new() { Prop = 71 }, new() { Prop = 72 } } | |||
There was a problem hiding this comment.
With regards to my comment above on target-typed, this is how I think it should be - explicitly type the list, implicitly the elements in the initializer...
ajcvickers
force-pushed
the
TimeOfTheSeasonForZombies
branch
from
bb1465d to
bb1607a
Compare
AndriySvyryd
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus some test refactoring to make cleanup go smoother next time.