Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Make nested generic type generation consistent #34537

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

AndriySvyryd
Copy link
Member

@AndriySvyryd AndriySvyryd commented Aug 26, 2024

Fixes #33710

Description

In some cases the code generated for compiled model does not correctly reference typed nested in generic types.

Customer impact

The generated compiled model doesn't compile and needs to be fixed manually after every time it's regenerated.

How found

Reported by a customer.

Regression

No.

Testing

Tests added.

Risk

Low. This code is only invoked at design-time.

@AndriySvyryd AndriySvyryd requested review from artl93 and a team August 26, 2024 23:42
Copy link
Member

@artl93 artl93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 approved based on scenario, but please get additional review from efteam.

@AndriySvyryd AndriySvyryd merged commit ab8e014 into release/9.0 Aug 27, 2024
7 checks passed
@AndriySvyryd AndriySvyryd deleted the Issue33710 branch August 27, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants