Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RC2) Downgrade to LTS SqlClient #34540

Merged
merged 2 commits into from
Aug 29, 2024
Merged

(RC2) Downgrade to LTS SqlClient #34540

merged 2 commits into from
Aug 29, 2024

Conversation

ajcvickers
Copy link
Contributor

Part of #32915

Description

We develop with the latest SqlClient package so that we have a better chance of catching regressions. However, we cannot release with this package because it has an open-ended support policy that may end before .NET 9/EF9 support ends. Therefore, we revert to the latest LTS package before release.

See SqlClient driver support lifecycle

Customer impact

Customer's get an LTS dependency by default. They can manually update to the non-LTS package.

How found

N/A

Regression

N/A

Testing

All tests pass with LTS version.

Risk

Low.

@ajcvickers ajcvickers requested a review from a team August 27, 2024 12:36
@ajcvickers
Copy link
Contributor Author

/cc @artl93

@ErikEJ
Copy link
Contributor

ErikEJ commented Aug 27, 2024

I really hope 5.1.6 will make the cut! It looks like it is planned for today

https://github.com/dotnet/SqlClient/pull/2769/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR219

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErikEJ yeah, we've been waiting for it for quite a while... but yeah, seems like it's about to go out.

@ajcvickers maybe hold back on merging until tomorrow or so?

@AndriySvyryd
Copy link
Member

5.1.6 was just released

@ErikEJ
Copy link
Contributor

ErikEJ commented Aug 28, 2024

LGTM 🙏

@ajcvickers
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ajcvickers
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ajcvickers ajcvickers merged commit c510e63 into release/9.0 Aug 29, 2024
7 checks passed
@ajcvickers ajcvickers deleted the AllYouCanEatSalad branch August 29, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants