Solves the problem of getting project MSBuild information

[paulomorgado]

This PR replaces the GetEFProjectMetadata target in EntityFrameworkCore.targets with Evaluate items and properties and display results of targets.

Fixes #23853
Fixes #30725

• I've read the guidelines for contributing and seen the walkthrough
• I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
• The code builds and tests pass locally (also verified by our automated build checks)
• Commit messages follow this format:

        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber

• Tests for the changes have been added (for bug fixes / features)
• Code follows the same patterns and style as existing code in this repo

[paulomorgado]

Hi @AndriySvyryd. Do you need anything from me on this PR?

[AndriySvyryd]

Ideally the PR should include tests, but we currently don't have the infrastructure for this. Once #33136 is done I'll take a look at the PR. It was submitted too late for 9.0 anyway, so there's no rush.

[paulomorgado]

I looked for the tests and couldn't find them.

You can reach out to someone at MSBuild to check this.

This can easily go to .NET 8.0, because the SDK supports it. I've been using this for a while.

[bricelam]

Fixes #32113

[bricelam]

Err wait, not quite. Remove --msbuildprojectextensionspath now, since it should no longer be needed.

[paulomorgado]

Err wait, not quite. Remove --msbuildprojectextensionspath now, since it should no longer be needed.

Was it, for sure, used only for this purpose? If it was, we should remove it.

[bricelam]

Yes. It just told us where to copy the MSBuild file

[paulomorgado]

Err wait, not quite. Remove --msbuildprojectextensionspath now, since it should no longer be needed.

Removed!

[paulomorgado]

Hi @AndriySvyryd,

Is anything missing from my part here?

[AndriySvyryd]

@paulomorgado No, it's on my radar.

[AndriySvyryd]

Thanks for your contribution!

[KennethHoff]

I'm assuming asking for a backport on this is a no-go? 😅

[paulomorgado]

I'm assuming this will be ported to all supported versions.

Some customers need LTS support.

[KennethHoff]

Generally speaking they don't backport "features" like this though

[paulomorgado]

This is safe to port to 8.

[bricelam]

Some customers need LTS support.

EF 10 will be LTS... 😏

[AndriySvyryd]

This is safe to port to 8.

Not with our definition. It changes the implementation significantly and there are no tests covering it.

[paulomorgado]

This is safe to port to 8.

Not with our definition. It changes the implementation significantly and there are no tests covering it.

I can port all the tests covering this in 9 to 8.

[AndriySvyryd]

I can port all the tests covering this in 9 to 8.

The are no tests. This has always been an issue. We only test ef.dll, but not the shims that use it.

#33136, #32616

[paulomorgado]

I can port all the tests covering this in 9 to 8.

The are no tests. This has always been an issue. We only test ef.dll, but not the shims that use it.

#33136, #32616

I know!

If it's good enough for 9, it's good enough for 8.

Or are you thinking on releasing this only for 10?

[AndriySvyryd]

Or are you thinking on releasing this only for 10?

Yes. Due to the above, this is a risky change that we only do early in the release to give early adopters enough time to exercise it before it's released to the general audience.