Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Map directly to JSON id for types converted to string #34577

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

ajcvickers
Copy link
Contributor

@ajcvickers ajcvickers commented Aug 30, 2024

Fixes #34554

Port of #34564

I intended this code for 9. Here it is. Merge it if you want.

Peace. Out. Most of it was fun.

* Map directly to JSON id for types converted to string

Fixes #34554

I also needed to fix #34511 to make this work. This was happening because we were removing the by-convention property added by property discovery. We only need to remove it when it's the computed property as well, which is handled by the other case.

* Updates
@AndriySvyryd AndriySvyryd requested a review from SamMonoRT August 30, 2024 20:35
@SamMonoRT SamMonoRT requested a review from artl93 August 30, 2024 20:53
@roji roji merged commit c7d5045 into release/9.0 Aug 31, 2024
7 checks passed
@roji roji deleted the SweetRedCherries branch August 31, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants