Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Update Azure.Identity version #34605

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

AndriySvyryd
Copy link
Member

No description provided.

@AndriySvyryd AndriySvyryd requested review from SamMonoRT and a team September 3, 2024 21:10
@AndriySvyryd AndriySvyryd requested a review from maumar as a code owner September 3, 2024 21:10
@AndriySvyryd AndriySvyryd changed the title [release/9.0] Remove Azure.Identity version override [release/9.0] Update Azure.Identity version Sep 3, 2024
@@ -39,7 +39,7 @@
<!-- NB: This version affects Visual Studio compatibility. See https://learn.microsoft.com/visualstudio/extensibility/roslyn-version-support -->
<MicrosoftCodeAnalysisVersion>4.8.0</MicrosoftCodeAnalysisVersion>
<MicrosoftCodeAnalysisTestingVersion>1.1.2-beta1.24121.1</MicrosoftCodeAnalysisTestingVersion>
<AzureIdentityVersion>1.11.3</AzureIdentityVersion>
<AzureIdentityVersion>1.12.0</AzureIdentityVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know how often we need to change this, and how other repos are handling the version updates?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least as often as new CVEs are found.
Most repos handle non-dotnet dependency updates manually.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependabot still doesn't work that well for arcade-style repos dependabot/dependabot-core#8490

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this apply to the Cosmos or SQL Server provider?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmos only - we have no direct dependency on Azure.Identity on the SQL Server side.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is only for tests

@AndriySvyryd AndriySvyryd merged commit b6bd805 into release/9.0 Sep 4, 2024
7 checks passed
@AndriySvyryd AndriySvyryd deleted the UpdateIdentity branch September 4, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants