Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for DropTable/CreateTable issue around temporal tables #35225

Closed
wants to merge 1 commit into from
Closed

Temporary fix for DropTable/CreateTable issue around temporal tables #35225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/EFCore.SqlServer/Migrations/SqlServerMigrationsSqlGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2606,9 +2606,8 @@ private IReadOnlyList<MigrationOperation> RewriteOperations(
operations.Add(operation);
}

// we removed the table, so we no longer need it's temporal information
// there will be no more operations involving this table
temporalTableInformationMap.Remove((tableName, schema));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We made a change last year to reduce the size of temporal table annotations in the model. See ##32239. Will this regress that at all?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, annotations are added in a different place

// Note that we leave the information in temporalTableInformationMap in case there's a later CreateTable operation
// on the same table name (see #35162).

break;
}
Expand Down