Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TINY] Fix to #35281 - Migrations: CreateTableBuilder<TColumns> Annotation(string name, object value) should accept object? instead #35297

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[TINY] Fix to #35281 - Migrations: CreateTableBuilder<TColumns> Annotation(string name, object value) should accept object? instead #35297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Migrations/Operations/Builders/CreateTableBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ public virtual OperationBuilder<AddCheckConstraintOperation> CheckConstraint(
/// <param name="name">The annotation name.</param>
/// <param name="value">The annotation value.</param>
/// <returns>The same builder so that multiple calls can be chained.</returns>
public new virtual CreateTableBuilder<TColumns> Annotation(string name, object value)
public new virtual CreateTableBuilder<TColumns> Annotation(string name, object? value)
=> (CreateTableBuilder<TColumns>)base.Annotation(name, value);

private string[] Map(LambdaExpression columns)
Expand Down
2 changes: 1 addition & 1 deletion test/EFCore.SqlServer.FunctionalTests/Migrations/MigrationsSqlServerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10881,7 +10881,7 @@ public virtual async Task Temporal_create_temporal_table_using_EF8_migration_cod
})
.Annotation("SqlServer:IsTemporal", true)
.Annotation("SqlServer:TemporalHistoryTableName", "CustomersHistory")
.Annotation("SqlServer:TemporalHistoryTableSchema", null!)
.Annotation("SqlServer:TemporalHistoryTableSchema", null)
.Annotation("SqlServer:TemporalPeriodEndColumnName", "PeriodEnd")
.Annotation("SqlServer:TemporalPeriodStartColumnName", "PeriodStart");

Expand Down