Skip to content

Commit

Permalink
Work around fixed bug in System.Memory.Data (#5569)
Browse files Browse the repository at this point in the history
* Workaround fixed bug in System.Memory.Data

BinaryData had a bug in its ToString that would throw an exception if _bytes was empty. That was fixed several years ago, but Azure SDK libraries are still referencing older versions of System.Memory.Data that don't have the fix.

* Add pragma warning and update condition check
  • Loading branch information
stephentoub authored Oct 24, 2024
1 parent 46d5e57 commit 4bff11a
Showing 1 changed file with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Licensed to the .NET Foundation under one or more agreements.
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
Expand All @@ -17,6 +17,7 @@
#pragma warning disable S1135 // Track uses of "TODO" tags
#pragma warning disable S3011 // Reflection should not be used to increase accessibility of classes, methods, or fields
#pragma warning disable SA1204 // Static elements should appear before instance elements
#pragma warning disable SA1108 // Block statements should not contain embedded comments

namespace Microsoft.Extensions.AI;

Expand Down Expand Up @@ -264,9 +265,10 @@ public async IAsyncEnumerable<StreamingChatCompletionUpdate> CompleteStreamingAs

existing.CallId ??= toolCallUpdate.ToolCallId;
existing.Name ??= toolCallUpdate.FunctionName;
if (toolCallUpdate.FunctionArgumentsUpdate is not null)
if (toolCallUpdate.FunctionArgumentsUpdate is { } update &&
!update.ToMemory().IsEmpty) // workaround for https://github.com/dotnet/runtime/issues/68262 in 6.0.0 package
{
_ = (existing.Arguments ??= new()).Append(toolCallUpdate.FunctionArgumentsUpdate);
_ = (existing.Arguments ??= new()).Append(update.ToString());
}
}
}
Expand Down

0 comments on commit 4bff11a

Please sign in to comment.