update version of SqlClient used by sql cache #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analogrelay
commented
Jul 10, 2019
| /// </summary> | ||
| public bool SkipOnMatch { get; set; } = true; | ||
| public bool RunOnMatch { get; set; } = true; |
There was a problem hiding this comment.
The behavior of this property doesn't at all match the old name, so I fixed it.
Tratcher
approved these changes
Jul 10, 2019
JunTaoLuo
approved these changes
Jul 11, 2019
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Got stale and I want a refreshed build before merging :) |
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
\n\nCommit migrated from dotnet/extensions@b1ff0d9
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
\n\nCommit migrated from dotnet/extensions@b1ff0d9
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Nov 17, 2020
\n\nCommit migrated from dotnet/extensions@b1ff0d9
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added a script to run the db tests (including re-creating database assets as necessary). And I added a
slnffor caching.NOTE: There is an issue in Microsoft.Data.SqlClient with transitive references: dotnet/SqlClient#137 . To mitigate this, I've added a direct reference from the SqlCache test project to
Microsoft.Data.SqlClient. As long as the linked issue is resolved by RTM (and we update to the RTM, which we plan to do) we can remove that hack.Also,
EnvironmentVariableSkipConditionAttribute.SkipOnMatchseems to behave completely opposite to how it's written... I think the confusion stems fromITestCondition.IsMetbeing intended to return true when the test should be run (actual behavior) rather than when the test should be skipped (presumed behavior).