Prkrishn/code coverage #2308
Prkrishn/code coverage #2308
Conversation
pranavkm
force-pushed
the
prkrishn/code-coverage
branch
from
ad455d5 to
b6f17b6
Compare
pranavkm
force-pushed
the
prkrishn/code-coverage
branch
from
b6f17b6 to
8c21ce3
Compare
|
/azp run all |
|
No pipelines are associated with this pull request. |
Don't tell me what to do. |
eng/common/build.ps1
Outdated
| @@ -13,6 +13,7 @@ Param( | |||
| [switch] $rebuild, | |||
| [switch] $deploy, | |||
| [switch][Alias('t')]$test, | |||
| [switch] $codeCoverage, | |||
There was a problem hiding this comment.
FYI I think you can just pass /p:CodeCoverage=true directly in CIBuild.cmd. This script is auto-updated by arcade and isn't meant to be edited.
There was a problem hiding this comment.
I was planning for this to be a target rather than a property. I do have some changes for Arcade, I'll work with them to figure out the right pattern.
|
Is this still in active development and/or will it be coming to aspnet/AspNetCore? I think this is super valuable information to have to advise your testing efforts. |
|
There's a PR in arcade to make this work - dotnet/arcade#3919 which isn't being actively looked at. I'd be happy if you'd like to drive it. |
|
@pranavkm a few questions
|
| "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19458.2", | ||
| "Microsoft.DotNet.Helix.Sdk": "2.0.0-beta.19458.2" | ||
| "Microsoft.DotNet.Arcade.Sdk": "4.0.0-dev", | ||
| "Microsoft.DotNet.Helix.Sdk": "2.0.0-beta.19454.31" |
There was a problem hiding this comment.
Do not change this portion of the file directly. Need to update the dependencies from Arcade i.e. get darc to change Versions.props and Version.Details.xml as well.
In your branch, execute
darc update-dependencies --source-repo arcade --channel '.NET Tools - Latest'or
darc update-dependencies --source-repo arcade --channel '.NET 3 Tools'| pathtoPublish: artifacts/log/$(_BuildConfig)/codecoverage/ | ||
| artifactName: $(Agent.Os)_$(Agent.JobName) CodeCoverage | ||
| artifactType: Container | ||
| parallel: true |
There was a problem hiding this comment.
Aren't these files included when all of artifacts/log is uploaded?
| @@ -108,20 +108,9 @@ stages: | |||
| arguments: 'locals all -clear' | |||
| - script: eng\common\cibuild.cmd -configuration $(_BuildConfig) -prepareMachine $(_BuildArgs) | |||
| displayName: Build and Publish | |||
| - script: eng\scripts\ci-flaky-tests.cmd -configuration $(_BuildConfig) | |||
| displayName: Run Flaky Tests | |||
| continueOnError: true | |||
There was a problem hiding this comment.
This doesn't look right. Why are you removing the flaky test run?
| @@ -0,0 +1,18 @@ | |||
| { | |||
There was a problem hiding this comment.
what will reference this new file?
ghost
locked as resolved and limited conversation to collaborators
Ignore