React to corefx changes #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym
force-pushed
the
feature/pk-corefx0
branch
from
ffae512 to
cd04314
Compare
natemcmaster
reviewed
Mar 8, 2018
| @@ -9,12 +9,12 @@ | |||
|
|
|||
| namespace System.IO.Pipelines.Tests | |||
| { | |||
| public class BufferWriterTes: IDisposable | |||
| public class BufferWriterTes : IDisposable | |||
There was a problem hiding this comment.
Nit: BufferWriterTes => BufferWriterTests
| if (currentCount <= 0) ThrowHelper.ThrowInvalidOperationException_ReferenceCountZero(); | ||
| if (Interlocked.CompareExchange(ref _referenceCount, currentCount - 1, currentCount) == currentCount) | ||
| { | ||
| // TODO: this needs to be changed to 1 when get Pipelines with pool fix. |
There was a problem hiding this comment.
I did change it to 1, just forgot to remove the comment.
pakrym
force-pushed
the
feature/pk-corefx0
branch
from
cd04314 to
3457833
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.