Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup default experimental URL #4130

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Setup default experimental URL #4130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@
<ItemGroup Condition="'$(Stage)' == 'dev' AND '$(OutputType)' != 'Exe' AND '$(Api)' != 'false'">
<AssemblyAttribute Include="System.Diagnostics.CodeAnalysis.ExperimentalAttribute">
<_Parameter1>TBD</_Parameter1>
<_Parameter2>UrlFormat = "https://aka.ms/dotnet-extensions-warnings/{0}"</_Parameter2>
<_Parameter2_IsLiteral>true</_Parameter2_IsLiteral>
</AssemblyAttribute>
</ItemGroup>
Comment on lines 78 to 84
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geeknoid FYI this essentially will be a no-op as the compiler won't provide support the assembly level - as noted in dotnet/roslyn#68702.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrajobst Do you have a recommendation on how to deal with this?

Right now, in this repo you can indicate a package is in dev stage. This means the whole package is in development, every API it contains is inherently experimental and the package may in fact be removed. With the Experimental attribute not being enforced at the assembly level, it would require engineers to mark every single public type in the assembly as experimental in order to make sure customers don't take an unintended dependency on the API.

Is this right? Shouldn't experimental support assembly scope?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrajobst Ping

Copy link
Member

@terrajobst terrajobst Jul 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was discussed here.

Basically, this doesn't work for obsolete today and we concluded we'd rather want to align with that for now and revisit if this is identified as a limitation. When I spec'ed it, I did include module and assembly level because that's what we did for the preview feature and platform compat attributes before and it seemed convenient, pretty much for the reason you're spelling out.

I think I'd prefer if the feature allowed for assembly level, but we should probably enable this for obsoletion as well then for consistency.

@jaredpar @jcouv what do you guys think? Should I file a separate issue so we can discuss this? No idea what the cost of such a change would be.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please file an issue. We (compiler) generally prefer module-level over assembly-level, but I understand that multi-module scenario is not a scenario with Core... So that might need some discussion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From discussion with Aleksey, supporting both assembly- and module-level would work and make sense for this attribute, without causing complications.


Expand Down
4 changes: 4 additions & 0 deletions eng/MSBuild/Shared.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
<Project>
<ItemGroup>
<Compile Include="$(MSBuildThisFileDirectory)\..\..\src\Shared\WarningDefinitions.cs" LinkBase="Shared" />
</ItemGroup>

<ItemGroup Condition="'$(InjectSharedThrow)' == 'true'">
<Compile Include="$(MSBuildThisFileDirectory)\..\..\src\Shared\Throw\*.cs" LinkBase="Shared\Throw" />
</ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion eng/packages/General.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
<ItemGroup>
<PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.5.22" />
<PackageVersion Include="SonarAnalyzer.CSharp" Version="8.52.0.60960" />
<PackageVersion Include="StyleCop.Analyzers.Unstable" Version="1.2.0.435" />
<PackageVersion Include="StyleCop.Analyzers.Unstable" Version="1.2.0.507" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net462'">
Expand Down
4 changes: 2 additions & 2 deletions src/Libraries/Microsoft.AspNetCore.Telemetry.Middleware/Logging/LoggingOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public class LoggingOptions
/// <value>
/// The default value is <see cref="HttpRouteParameterRedactionMode.Strict"/>.
/// </value>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public HttpRouteParameterRedactionMode RequestPathParameterRedactionMode { get; set; } = DefaultPathParameterRedactionMode;

/// <summary>
Expand Down Expand Up @@ -208,7 +208,7 @@ public class LoggingOptions
/// };
/// </code>
/// </example>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[Required]
[SuppressMessage("Usage", "CA2227:Collection properties should be read only",
Justification = "Options pattern.")]
Expand Down
2 changes: 1 addition & 1 deletion ...rosoft.AspNetCore.Telemetry/Enrichment.RequestHeaders/RequestHeadersLogEnricherOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public class RequestHeadersLogEnricherOptions
/// Default value is an empty dictionary.
/// </remarks>
[Required]
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
#pragma warning disable CA2227 // Collection properties should be read only
public IDictionary<string, DataClassification> HeadersDataClasses { get; set; } = new Dictionary<string, DataClassification>();
#pragma warning restore CA2227 // Collection properties should be read only
Expand Down
4 changes: 2 additions & 2 deletions src/Libraries/Microsoft.AspNetCore.Telemetry/Tracing/HttpTracingExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ public static TracerProviderBuilder AddHttpTraceEnricher(this TracerProviderBuil
/// <param name="services">The <see cref="IServiceCollection"/> to add this enricher.</param>
/// <returns><see cref="IServiceCollection"/> for chaining.</returns>
/// <exception cref="ArgumentNullException">The argument <paramref name="services"/> is <see langword="null"/>.</exception>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public static IServiceCollection AddHttpTraceEnricher<T>(this IServiceCollection services)
where T : class, IHttpTraceEnricher
{
Expand All @@ -132,7 +132,7 @@ public static IServiceCollection AddHttpTraceEnricher<T>(this IServiceCollection
/// <param name="enricher">Enricher to be added.</param>
/// <returns><see cref="TracerProviderBuilder"/> for chaining.</returns>
/// <exception cref="ArgumentNullException">The argument <paramref name="services"/> or <paramref name="enricher"/> is <see langword="null" />.</exception>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public static IServiceCollection AddHttpTraceEnricher(this IServiceCollection services, IHttpTraceEnricher enricher)
{
_ = Throw.IfNull(services);
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.AspNetCore.Telemetry/Tracing/HttpTracingOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public class HttpTracingOptions
/// <remarks>
/// This property is applicable when the <see cref="IncludePath"/> option is enabled.
/// </remarks>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public HttpRouteParameterRedactionMode RequestPathParameterRedactionMode { get; set; } = DefaultPathParameterRedactionMode;

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.AsyncState/IAsyncLocalContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Microsoft.Extensions.AsyncState;
/// </summary>
/// <typeparam name="T">The type of the asynchronous state.</typeparam>
/// <remarks>This type is intended for internal use. Use <see cref="IAsyncContext{T}"/> instead.</remarks>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[EditorBrowsable(EditorBrowsableState.Never)]
#pragma warning disable S4023 // Interfaces should not be empty
public interface IAsyncLocalContext<T> : IAsyncContext<T>
Expand Down
4 changes: 2 additions & 2 deletions ...nsions.Diagnostics.HealthChecks.Common/CommonHealthChecksExtensions.TelemetryPublisher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public static IServiceCollection AddTelemetryHealthCheckPublisher(this IServiceC
/// <param name="section">Configuration for <see cref="TelemetryHealthCheckPublisherOptions"/>.</param>
/// <returns>The value of <paramref name="services"/>.</returns>
/// <exception cref="ArgumentNullException"><paramref name="services" /> or <paramref name="section"/> are <see langword="null" />.</exception>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public static IServiceCollection AddTelemetryHealthCheckPublisher(this IServiceCollection services, IConfigurationSection section)
=> Throw.IfNull(services)
.Configure<TelemetryHealthCheckPublisherOptions>(Throw.IfNull(section))
Expand All @@ -44,7 +44,7 @@ public static IServiceCollection AddTelemetryHealthCheckPublisher(this IServiceC
/// <param name="configure">Configuration for <see cref="TelemetryHealthCheckPublisherOptions"/>.</param>
/// <returns>The value of <paramref name="services"/>.</returns>
/// <exception cref="ArgumentNullException"><paramref name="services" /> or <paramref name="configure"/> are <see langword="null" />.</exception>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public static IServiceCollection AddTelemetryHealthCheckPublisher(this IServiceCollection services, Action<TelemetryHealthCheckPublisherOptions> configure)
=> Throw.IfNull(services)
.Configure(Throw.IfNull(configure))
Expand Down
2 changes: 1 addition & 1 deletion ...rosoft.Extensions.Diagnostics.HealthChecks.Common/TelemetryHealthCheckPublisherOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace Microsoft.Extensions.Diagnostics.HealthChecks;
/// <summary>
/// Options for the telemetry health check publisher.
/// </summary>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public class TelemetryHealthCheckPublisherOptions
{
/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion ...ibraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/ResourceMonitoringOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public class ResourceMonitoringOptions
/// The value needs to be less than or equal to the <see cref="CollectionWindow"/>.
/// Most importantly, this period is used to calculate <see cref="Utilization"/> instances pushed to publishers.
/// </remarks>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[TimeSpan(MinimumSamplingWindow, MaximumSamplingWindow)]
public TimeSpan CalculationPeriod { get; set; } = DefaultCollectionWindow;
}
4 changes: 2 additions & 2 deletions ...ies/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Windows/WindowsCountersOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace Microsoft.Extensions.Diagnostics.ResourceMonitoring;
/// <summary>
/// Options for WindowsCounters.
/// </summary>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public class WindowsCountersOptions
{
internal const int MinimumCachingInterval = 100;
Expand All @@ -33,7 +33,7 @@ public class WindowsCountersOptions
/// <value>
/// The default value is 5 seconds.
/// </value>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[TimeSpan(MinimumCachingInterval, MaximumCachingInterval)]
public TimeSpan CachingInterval { get; set; } = DefaultCachingInterval;
}
6 changes: 3 additions & 3 deletions ...crosoft.Extensions.Diagnostics.ResourceMonitoring/Windows/WindowsUtilizationExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public static IResourceMonitorBuilder AddWindowsPerfCounterPublisher(this IResou
/// <returns>The value of <paramref name="builder" />.</returns>
/// <exception cref="ArgumentNullException"><paramref name="builder"/> is <see langword="null" />.</exception>
/// <seealso cref="System.Diagnostics.Metrics.Instrument"/>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public static IResourceMonitorBuilder AddWindowsCounters(this IResourceMonitorBuilder builder)
{
_ = Throw.IfNull(builder);
Expand Down Expand Up @@ -93,7 +93,7 @@ public static IResourceMonitorBuilder AddWindowsCounters(this IResourceMonitorBu
/// <returns>The value of <paramref name="builder"/>.</returns>
/// <exception cref="ArgumentNullException"><paramref name="builder"/> is <see langword="null" />.</exception>
/// <seealso cref="System.Diagnostics.Metrics.Instrument"/>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public static IResourceMonitorBuilder AddWindowsCounters(this IResourceMonitorBuilder builder, IConfigurationSection section)
{
_ = Throw.IfNull(builder);
Expand Down Expand Up @@ -123,7 +123,7 @@ public static IResourceMonitorBuilder AddWindowsCounters(this IResourceMonitorBu
/// <returns>The value of <paramref name="builder"/>.</returns>
/// <exception cref="ArgumentNullException"><paramref name="builder"/> is <see langword="null" />.</exception>
/// <seealso cref="System.Diagnostics.Metrics.Instrument"/>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public static IResourceMonitorBuilder AddWindowsCounters(this IResourceMonitorBuilder builder, Action<WindowsCountersOptions> configure)
{
_ = Throw.IfNull(builder);
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Hosting.Testing/HostingFakesExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace Microsoft.Extensions.Hosting.Testing;
/// <summary>
/// Extension methods supporting host unit testing scenarios.
/// </summary>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public static class HostingFakesExtensions
{
/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/AutoClientAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// }
/// </code>
/// </example>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[AttributeUsage(AttributeTargets.Interface)]
[Conditional("CODE_GENERATION_ATTRIBUTES")]
public sealed class AutoClientAttribute : Attribute
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/AutoClientException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// </code>
/// </example>
[SuppressMessage("Design", "CA1032:Implement standard exception constructors", Justification = "Not applicable to this exception")]
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public class AutoClientException : Exception
{
/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/AutoClientHttpError.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// When a REST API client fails, it will throw a <see cref="AutoClientException"/>.
/// This exception contains a <see cref="AutoClientHttpError"/> instance that holds details like content, headers and status code.
/// </remarks>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public class AutoClientHttpError
{
/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/AutoClientOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// });
/// </code>
/// </example>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public class AutoClientOptions
{
/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/BodyAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// }
/// </code>
/// </example>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[AttributeUsage(AttributeTargets.Parameter)]
[Conditional("CODE_GENERATION_ATTRIBUTES")]
public sealed class BodyAttribute : Attribute
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/BodyContentType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// <summary>
/// Defines the types of encoding possible for request bodies.
/// </summary>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public enum BodyContentType
{
/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/HeaderAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// }
/// </code>
/// </example>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[AttributeUsage(AttributeTargets.Parameter)]
[Conditional("CODE_GENERATION_ATTRIBUTES")]
public sealed class HeaderAttribute : Attribute
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/Methods/DeleteAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// }
/// </code>
/// </example>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[AttributeUsage(AttributeTargets.Method)]
public sealed class DeleteAttribute : Attribute
{
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/Methods/GetAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// }
/// </code>
/// </example>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[AttributeUsage(AttributeTargets.Method)]
public sealed class GetAttribute : Attribute
{
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/Methods/HeadAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// }
/// </code>
/// </example>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[AttributeUsage(AttributeTargets.Method)]
public sealed class HeadAttribute : Attribute
{
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/Methods/OptionsAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// }
/// </code>
/// </example>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[AttributeUsage(AttributeTargets.Method)]
public sealed class OptionsAttribute : Attribute
{
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/Methods/PatchAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// }
/// </code>
/// </example>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[AttributeUsage(AttributeTargets.Method)]
public sealed class PatchAttribute : Attribute
{
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/Methods/PostAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// }
/// </code>
/// </example>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[AttributeUsage(AttributeTargets.Method)]
public sealed class PostAttribute : Attribute
{
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/Methods/PutAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// }
/// </code>
/// </example>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[AttributeUsage(AttributeTargets.Method)]
public sealed class PutAttribute : Attribute
{
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/QueryAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// }
/// </code>
/// </example>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[AttributeUsage(AttributeTargets.Parameter)]
[Conditional("CODE_GENERATION_ATTRIBUTES")]
public sealed class QueryAttribute : Attribute
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/RequestNameAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// }
/// </code>
/// </example>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[AttributeUsage(AttributeTargets.Method)]
[Conditional("CODE_GENERATION_ATTRIBUTES")]
public sealed class RequestNameAttribute : Attribute
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.AutoClient/StaticHeaderAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace Microsoft.Extensions.Http.AutoClient;
/// }
/// </code>
/// </example>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[AttributeUsage(AttributeTargets.Interface | AttributeTargets.Method, AllowMultiple = true)]
[Conditional("CODE_GENERATION_ATTRIBUTES")]
public sealed class StaticHeaderAttribute : Attribute
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/Microsoft.Extensions.Http.Resilience/FaultInjection/ContextExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Microsoft.Extensions.Http.Resilience.FaultInjection;
/// <summary>
/// Provides extension methods for <see cref="Context"/>.
/// </summary>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public static class ContextExtensions
{
private const string CallingRequestMessage = "CallingRequestMessage";
Expand Down
4 changes: 2 additions & 2 deletions ...Microsoft.Extensions.Http.Resilience/FaultInjection/HttpClientFaultInjectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public static IHttpClientBuilder AddFaultInjectionPolicyHandler(this IHttpClient
/// <returns>
/// The <see cref="IHttpClientBuilder"/> so that additional calls can be chained.
/// </returns>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public static IHttpClientBuilder AddWeightedFaultInjectionPolicyHandlers(this IHttpClientBuilder httpClientBuilder,
Action<FaultPolicyWeightAssignmentsOptions> weightAssignmentsConfig)
{
Expand Down Expand Up @@ -176,7 +176,7 @@ public static IHttpClientBuilder AddWeightedFaultInjectionPolicyHandlers(this IH
/// <returns>
/// The <see cref="IHttpClientBuilder"/> so that additional calls can be chained.
/// </returns>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
[DynamicDependency(
DynamicallyAccessedMemberTypes.PublicProperties | DynamicallyAccessedMemberTypes.PublicParameterlessConstructor,
typeof(FaultPolicyWeightAssignmentsOptions))]
Expand Down
2 changes: 1 addition & 1 deletion ...s/Microsoft.Extensions.Http.Resilience/Hedging/StandardHedgingHandlerBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public static IStandardHedgingHandlerBuilder Configure(this IStandardHedgingHand
/// <param name="builder">The strategy builder.</param>
/// <param name="configure">The configure method.</param>
/// <returns>The same builder instance.</returns>
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public static IStandardHedgingHandlerBuilder Configure(this IStandardHedgingHandlerBuilder builder, Action<HttpStandardHedgingResilienceOptions, IServiceProvider> configure)
{
_ = Throw.IfNull(builder);
Expand Down
2 changes: 1 addition & 1 deletion ...t.Extensions.Http.Resilience/Resilience/HttpStandardResilienceBuilderBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public static IHttpStandardResilienceStrategyBuilder Configure(this IHttpStandar
/// <param name="configure">The configure method.</param>
/// <returns>The same builder instance.</returns>
#pragma warning disable S3872 // Parameter names should not duplicate the names of their methods
[Experimental(diagnosticId: "TBD", UrlFormat = "TBD")]
[Experimental(diagnosticId: "TBD", UrlFormat = WarningDefinitions.SharedUrlFormat)]
public static IHttpStandardResilienceStrategyBuilder Configure(this IHttpStandardResilienceStrategyBuilder builder, Action<HttpStandardResilienceOptions, IServiceProvider> configure)
#pragma warning restore S3872 // Parameter names should not duplicate the names of their methods
{
Expand Down
Loading