Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Add workflow for automatic SDK updates #4887

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 17, 2024

Backport of #4886 to main

/cc @wtgodbe

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Microsoft Reviewers: Open in CodeFlow

@wtgodbe wtgodbe requested a review from RussKie January 17, 2024 19:58
@wtgodbe
Copy link
Member

wtgodbe commented Jan 17, 2024

@RussKie looks like the action has to be in the default branch. I updated the args so it'll open the PR against dev even though the action is in main.

@RussKie
Copy link
Member

RussKie commented Jan 17, 2024

Thank you

@RussKie RussKie merged commit e262cd6 into main Jan 17, 2024
2 checks passed
@RussKie RussKie deleted the backport/pr-4886-to-main branch January 17, 2024 20:00
@ghost ghost added this to the 8.1 milestone Jan 17, 2024
with:
quality: 'daily'
repo-token: ${{ secrets.GITHUB_TOKEN }}
branch-name: dev
Copy link
Member

@martincostello martincostello Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wtgodbe This isn’t right - you need to tell the checkout action to clone the dev branch instead of telling this action to create a branch called dev.

I’ll add an example of this to my action’s README to make this clearer.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants