Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Microsoft.Extensions.AuditReports output path #4945

Merged
merged 10 commits into from
Mar 5, 2024
Merged

Fix Microsoft.Extensions.AuditReports output path #4945

merged 10 commits into from
Mar 5, 2024

Conversation

xakep139
Copy link
Contributor

@xakep139 xakep139 commented Feb 14, 2024 •
edited by dotnet-policy-service bot
Loading

Microsoft Reviewers: Open in CodeFlow

@xakep139 xakep139 requested a review from geeknoid February 14, 2024 14:43
@xakep139
Copy link
Contributor Author

@joperezr is my understanding correct, that it will land in 8.3?

@joperezr
Copy link
Member

Correct, all changes going into main now, up until 1 week before the release, will be included in 8.3

joperezr
joperezr approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While not directly related to this, but would it be possible to also use this PR to finish up the README for this package? Right now there is basically no docs at all so the only way to consume this package is to know about it, and then to know how to read MSBuild in order to figure out what needs to be done in order to generate the reports.

@xakep139
Copy link
Contributor Author

While not directly related to this, but would it be possible to also use this PR to finish up the README for this package? Right now there is basically no docs at all so the only way to consume this package is to know about it, and then to know how to read MSBuild in order to figure out what needs to be done in order to generate the reports.

Good point, will fill README

@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Gen.MetricsReports Line 65 64.53 🔻

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=568163&view=codecoverage-tab

@xakep139
simplify logic;
b2964e3 
increase test coverage
@xakep139 xakep139 marked this pull request as draft February 19, 2024 11:06
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Gen.ComplianceReports Line 96 94.21 🔻

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=571871&view=codecoverage-tab

xakep139
xakep139 commented Feb 29, 2024
View reviewed changes
global.json Show resolved Hide resolved
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Gen.ComplianceReports Line 96 94.21 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Gen.MetricsReports 65 67

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=584533&view=codecoverage-tab

@xakep139 xakep139 marked this pull request as ready for review March 4, 2024 19:01
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Gen.MetricsReports 65 67
Microsoft.Gen.ComplianceReports 96 98

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=589228&view=codecoverage-tab

@xakep139 xakep139 merged commit 52350a9 into main Mar 5, 2024
6 checks passed
@xakep139 xakep139 deleted the xakep139/fix-audit-reports-output-path branch March 5, 2024 11:23
@xakep139 xakep139 added this to the 8.3 milestone Mar 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RussKie RussKie RussKie left review comments

@joperezr joperezr joperezr approved these changes

@mobratil mobratil mobratil approved these changes

@dariusclay dariusclay dariusclay approved these changes

@geeknoid geeknoid Awaiting requested review from geeknoid

Assignees

@xakep139 xakep139

Labels
None yet
Projects
None yet
Milestone
8.3
Development

Successfully merging this pull request may close these issues.
6 participants
@xakep139 @joperezr @dotnet-comment-bot @dariusclay @RussKie @mobratil