Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect diagnostic value. #4994

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Fix incorrect diagnostic value. #4994

merged 1 commit into from
Mar 8, 2024

Conversation

geeknoid
Copy link
Member

@geeknoid geeknoid commented Mar 7, 2024

  • VSTHRD114 appears in two different assemblies, and so shows up twice in the diagnostics yaml
    files. Both uses should be configured consistently. The only manual change here is in the .yml file,
    everything else is generated by
    scripts/MakeEditorConfigs.ps1

Fixed #4991

Microsoft Reviewers: Open in CodeFlow

- VSTHRD114 appears in two different assemblies,
and so shows up twice in the diagnostics yaml
files. Both uses should be configured consistently.
The only manual change here is in the .yml file,
everything else is generated by
scripts/MakeEditorConfigs.ps1

Fixed #4991
@geeknoid geeknoid requested a review from xakep139 March 7, 2024 23:44
@geeknoid geeknoid enabled auto-merge (squash) March 7, 2024 23:44
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Gen.MetricsReports 65 67
Microsoft.Gen.ComplianceReports 96 98

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=594376&view=codecoverage-tab

@geeknoid geeknoid merged commit 5db5909 into main Mar 8, 2024
6 checks passed
@geeknoid geeknoid deleted the geeknoid/diags branch March 8, 2024 00:08
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSTHRD114 duplicate
3 participants