-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FakeTimeProvider usage update #5169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
var retries = 42; | ||
var tries = 0; | ||
var taskDelay = 0.5; | ||
var delay = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use var
for intrinsic types.
} | ||
|
||
// Act | ||
var result = simulatedPollyRetry(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use var
unless the type is obvious.
https://github.com/dotnet/runtime/blob/main/docs/coding-guidelines/coding-style.md #10
Closes #4912
Adds additional test and information regarding usage of FakeTimeProvider
Microsoft Reviewers: Open in CodeFlow