Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the AIFunctionFactory APIs and remove redundant overloads following removal of trimmer annotations. #5510

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Oct 11, 2024

Follow-up work to #5507

Microsoft Reviewers: Open in CodeFlow

Verified

This commit was signed with the committer’s verified signature.
mp911de Mark Paluch
…owing removal of trimmer annotations.
@eiriktsarpalis
Copy link
Member Author

I pushed more changes adding a new MethodInfo overload that matches the Delegate accelerator. One source breaking change this introduces is making the object? target parameter non-optional. I think this is goodness because it forces users to be deliberate as to whether they're passing a static or instance method.

@eiriktsarpalis eiriktsarpalis merged commit 6249779 into dotnet:main Oct 11, 2024
6 checks passed
@eiriktsarpalis eiriktsarpalis deleted the remote-redundant-overloads branch October 11, 2024 17:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants