Add AdditionalPropertiesDictionary.TryGetValue<T> #5528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Libraries/Microsoft.Extensions.AI.Abstractions/AdditionalPropertiesDictionary.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Oct 16, 2024
| /// If a non-<see langword="null"/> is found for the key in the dictionary, but the value is not of the requested type but is | ||
| /// an <see cref="IConvertible"/> object, the method will attempt to convert the object to the requested type. | ||
| /// </remarks> | ||
| public bool TryGetValue<T>(string key, [NotNullWhen(true)] out T? value) |
There was a problem hiding this comment.
Should we explicitly ban nullable type parameters?
Suggested change
| public bool TryGetValue<T>(string key, [NotNullWhen(true)] out T? value) | |
| public bool TryGetValue<T>(string key, [NotNullWhen(true)] out T? value) where T : notnull |
There was a problem hiding this comment.
What does that help? The parameter is already nullable in the case of reference types.
There was a problem hiding this comment.
It explicitly prevents passing nullable type parameters even if it doesn't change the nullability of the out parameter.
There was a problem hiding this comment.
Right, but what benefit does that provide here? What errors does it avoid? It seems like it'd only be a hindrance here, eg not being able to use this in a method with an unconstrained T. This T is only ever in an out position, and the out is already nullable regardless of the T.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5526
Microsoft Reviewers: Open in CodeFlow