Improve EmbeddingGeneratorExtensions #5551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Libraries/Microsoft.Extensions.AI.Abstractions/Embeddings/EmbeddingGeneratorExtensions.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.Abstractions/Embeddings/EmbeddingGeneratorExtensions.cs
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Oct 22, 2024
src/Libraries/Microsoft.Extensions.AI.Abstractions/Embeddings/EmbeddingGeneratorExtensions.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.Abstractions/Embeddings/EmbeddingGeneratorExtensions.cs
Outdated
Show resolved
Hide resolved
- Renames GenerateAsync extension method (not the interface method) to be GenerateEmbeddingAsync, since it produces a single TEmbedding - Adds GenerateEmbeddingVectorAsync, which returns a `ReadOnlyMemory<T>` - Adds a GenerateAndZipEmbeddingsAsync, which creates a `List<KeyValuePair<TInput, TEmbedding>>` that pairs the inputs with the outputs.
stephentoub
force-pushed
the
embeddingextensions
branch
from
41abe1e to
c9c06da
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SteveSandersonMS, @eiriktsarpalis, @luisquintanilla, this is related to our discussion this morning.
We end up with:
GenerateAsyncthat returnsGeneratedEmbeddingsGenerateEmbeddingAsyncthat returns aTEmbeddingGenerateEmbeddingVectorAsyncthat returns aReadOnlyMemory<T>GenerateAndZipEmbeddingsAsyncthat returns aList<KVP<TInput, TEmbedding>>Microsoft Reviewers: Open in CodeFlow