HybridCache: don't log cancellation as failure event #5601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR feedback from #5467
If the operation is cancelled, do not report as a failure; we still need to decrement the counters, and there is a new corresponding event (at level "verbose" rather than "error")
Note: intentionally doesn't demand that
OperationCanceledException.Tokenis correctly set, as that can be a little brittle; if we see anOperationCanceledExceptionandSharedTokenis marked as cancelled: that's good enough to assume that the two things are related, at least enough for logging purposes./cc @BrennanConroy
Microsoft Reviewers: Open in CodeFlow