Remove duplicate GetCacheKey methods #5651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate to only the `ReadOnlySpan<object>`-based method.
shyamnamboodiripad
approved these changes
Nov 18, 2024
src/Libraries/Microsoft.Extensions.AI/ChatCompletion/DistributedCachingChatClient.cs
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI/ChatCompletion/DistributedCachingChatClient.cs
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Nov 18, 2024
stephentoub
added a commit
to stephentoub/extensions
that referenced
this pull request
Nov 19, 2024
* Remove duplicate GetCacheKey methods Consolidate to only the `ReadOnlySpan<object>`-based method. * Update XML comments to say that the values are serialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate to only the
ReadOnlySpan<object>-based method.@shyamnamboodiripad, does this address your concerns (#5641 (comment))?
Microsoft Reviewers: Open in CodeFlow