Tweak CachingHelpers.GetCacheKey to clean up better on failure #5654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveSandersonMS
approved these changes
Nov 19, 2024
stephentoub
added a commit
to stephentoub/extensions
that referenced
this pull request
Nov 19, 2024
| // If we start using an instance, write to it, and then fail, we will have left it | ||
| // in an inconsistent state. So, when renting it, we null it out, and we only put | ||
| // it back upon successful completion after resetting it. | ||
| IncrementalHashStream.ThreadStaticInstance = null; |
There was a problem hiding this comment.
Why not just dispose it in a try/finally? Is it expected that this could be called recursively?
There was a problem hiding this comment.
It shouldn't be disposed if it's going to be cached. So it's disposed in a catch rather than a finally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow