Change UseLogging to accept an ILoggerFactory instead of ILogger #5682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fits better with DI, and makes it consistent with UseFunctionInvocation and UseOpenTelemetry.
stephentoub
force-pushed
the
useloggingfactory
branch
from
8b4b8e5
to
16fe41f
Compare
SteveSandersonMS
approved these changes
Nov 20, 2024
stephentoub
added a commit
to stephentoub/extensions
that referenced
this pull request
Nov 20, 2024
…net#5682) Fits better with DI, and makes it consistent with UseFunctionInvocation and UseOpenTelemetry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fits better with DI, and makes it consistent with UseFunctionInvocation and UseOpenTelemetry.
Microsoft Reviewers: Open in CodeFlow